Update all tests to check for non-empty config_lists. #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afourney
requested review from
a team,
rickyloynd-microsoft,
sonichi and
yiranwu0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
+ Coverage 30.14% 37.71% +7.56%
==========================================
Files 30 30
Lines 4020 4020
Branches 908 957 +49
==========================================
+ Hits 1212 1516 +304
+ Misses 2729 2391 -338
- Partials 79 113 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Dec 28, 2023
Member
Author
|
Will fix with #1082 |
afourney
removed request for
a team,
rickyloynd-microsoft,
sonichi and
yiranwu0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Almost all the tests load a config_list without checking if it actually loaded anything. I noticed this with test_compressible_agent #1072 and #1073, but the problem is pervasive.
If the list is empty, it will silently default to GPT-4, and that's definitely not what we want. As seen here, it masks costly misconfigurations!
Related issue number
#1072 and #1073
Checks